Added direct upload from video camera #12995

timedin-de · 2024-05-09T14:09:50Z

Regarding feature request #7358

Adding Option to directly upload a video
If camera permissions are not already granted, it will ask if for video or image after granting (its seems not not to be possible to get the camera-action after the permission request)
It seems that the videointent doesn't work on emulator?
Tested successfull with a real GooglePixel 6a
Tests written, or not not needed

alperozturk96

Thanks for the contribution.

I try to upload video directly on Android 14 emulator, after completing video shooting upload didn't work. The video file didn't upload.

After my second attempt, the app is crashed. Logcat didn't show any crash log for nextcloud package and general android

Could you test via Android 14 emulator and share your findings with us?

timedin-de · 2024-05-14T07:39:24Z

Thanks for the contribution.

I try to upload video directly on Android 14 emulator, after completing video shooting upload didn't work. The video file didn't upload.

After my second attempt, the app is crashed. Logcat didn't show any crash log for nextcloud package and general android

Could you test via Android 14 emulator and share your findings with us?

Thanks for testing, thats what i meant with "It seems that the videointent doesn't work on emulator?", I tried countless times using the videointent on an emulator and it crashes or exits. I currently have no idea why this happens. On a hardware phone (Pixel 6a) it just works... (i was unsure if it was maybe just my underpowered laptop, but this ensures the bug)

I'll try some tests with only video intents (outside of the nextcloup app) on emulator to check for the issue.

timedin-de · 2024-05-21T10:20:31Z

Hey, I'm sorry, but I currently don't have the time (and motivation) to further check on this issue in the emulator. Maybe someone else finds the problem, or just discard the PR?

alperozturk96 · 2024-05-21T12:25:57Z

Hey, I'm sorry, but I currently don't have the time (and motivation) to further check on this issue in the emulator. Maybe someone else finds the problem, or just discard the PR?

I'll check it. Thank you for your contribution; it's wonderful to see support from the community 👍

JonasMayerDev · 2024-05-21T14:05:28Z

For me, the PR seems to work on real device (One Plus running Android 12).

JonasMayerDev · 2024-05-21T14:14:51Z

What do you think of not having 2 different "upload from camera" in the Dialog Fragment but just one and then showing the user the dialog that's currently shown when accepting the permissions with the options video and image? I think the DialogFragment is already a little crowded, and it would make the experience a little more consistent since the dialog is currently only shown once regardless if "upload from camera" or "upload from video camera" is clicked...

@alperozturk96 @timedin-de What do you think?

timedin-de · 2024-05-22T09:06:01Z

@timedin-de What do you think?

Yep I could do it this way if you agree on it.
It would mean one more click to open the camera, but i think would cause less confusion, (especially the current additional prompt after the permission granting).

I chose the current approach because of the comment in the issue
by @joshtrichards in #7358 (comment)

JonasMayerDev · 2024-05-22T11:16:23Z

@timedin-de thank you! I guess the best persons to decide on that is the design team @nextcloud/designers
To summarize for them:

Option 1 for adding a "capture video" implementation would look something like this:

Pro: One click video capture
Con: Too crowded dialog when clicking plus button, Inconsistent since dialog from option 2 would still show once when accepting video permissions.

Option 2 would look something like this:

Pro: Consistent, less crowded
Con: 2 Clicks for video capture

szaimen · 2024-05-22T11:32:49Z

Honestly I dont unterstand what is the difference between upload from camera and upload from video camera?

timedin-de · 2024-05-22T14:39:07Z

Honestly I dont unterstand what is the difference between upload from camera and upload from video camera?

On Android when a camera gets started it needs to be specified if it should record a video or take a picture (you cant decide/change it inside of the camera preview).

So "video camera" starts in video-recording-mode, "camera" in photo-mode

szaimen · 2024-05-22T14:46:48Z

I see. Then maybe rename the entries to Take a video and upload and Take a photo and upload ?

JonasMayerDev · 2024-05-22T18:19:40Z

@szaimen Yes good point. But the question is if we should even use 2 separate buttons (video and image) when clicking on the plus in the app. Or if we combine it in one button and the ask the user in a dialog if he wants video or image (prefered option for me and Alper). Take a look at my message for the pro and cons in my opinion: #12995 (comment)

github-actions · 2024-05-24T01:45:38Z

Hello there,
Thank you so much for taking the time and effort to create a pull request to our Nextcloud project.

We hope that the review process is going smooth and is helpful for you. We want to ensure your pull request is reviewed to your satisfaction. If you have a moment, our community management team would very much appreciate your feedback on your experience with this PR review process.

Your feedback is valuable to us as we continuously strive to improve our community developer experience. Please take a moment to complete our short survey by clicking on the following link: https://cloud.nextcloud.com/apps/forms/s/i9Ago4EQRZ7TWxjfmeEpPkf6

Thank you for contributing to Nextcloud and we hope to hear from you soon!

szaimen · 2024-05-28T14:24:49Z

I would probably indeed combine these two things into one option:
Take photo or video and upload and keep using the camera icon.

Then if clicking on that, indeed open a popup and ask this question but put the photo button to the right as it is more likely that you want to take a photo imho.

timedin-de · 2024-05-28T14:53:23Z

I would probably indeed combine these two things into one option:
Take photo or video and upload

So change the text for the file-action, instead of leaving it "Upload from camera"?

JonasMayerDev · 2024-05-28T15:03:23Z

@timedin-de @szaimen I would leave it as it was. "Take photo or video and upload" feels a little long, an "Upload from camera" is already expressive enough in my opinion?

szaimen · 2024-05-28T15:12:15Z

@timedin-de @szaimen I would leave it as it was. "Take photo or video and upload" feels a little long, an "Upload from camera" is already expressive enough in my opinion?

I think "Take photo or video and upload" is better but if it is too long "Upload from camera" should work as well

timedin-de · 2024-05-28T17:15:16Z

Ok I left it on "Upload from camera".

For implementation I moved the permissons-code from FileOperationsHelper to OCFileListFragment, I thought the dialog should be part of the Fragment not the FileHelper. Hit me up if I should change it.

timedin-de · 2024-05-28T17:17:24Z

app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java

@@ -443,7 +444,7 @@ public void onRequestPermissionsResult(int requestCode, @NonNull String[] permis
                // If request is cancelled, result arrays are empty.
                if (grantResults.length > 0 && grantResults[0] == PackageManager.PERMISSION_GRANTED) {
                    // permission was granted
-                    getFileOperationsHelper().uploadFromCamera(this, FileDisplayActivity.REQUEST_CODE__UPLOAD_FROM_CAMERA);
+                    getOCFileListFragmentFromFile().directCameraUpload();


displaying the dialog in OCFileListFragment

timedin-de · 2024-05-28T17:18:10Z

app/src/main/java/com/owncloud/android/ui/activity/FileDisplayActivity.java


                        if (!file.renameTo(renamedFile)) {
-                            DisplayUtils.showSnackMessage(getActivity(), "Fail to upload taken image!");
+                            DisplayUtils.showSnackMessage(getActivity(), R.string.error_uploading_direct_camera_upload);


not regarding the video-upload itself, small improvement

timedin-de · 2024-05-28T17:18:55Z

app/src/main/java/com/owncloud/android/ui/fragment/OCFileListBottomSheetDialog.java

+        viewThemeUtils.platform.colorImageView(binding.menuIconUploadFiles, ColorRole.PRIMARY);
+        viewThemeUtils.platform.colorImageView(binding.menuIconUploadFromApp, ColorRole.PRIMARY);
+        viewThemeUtils.platform.colorImageView(binding.menuIconDirectCameraUpload, ColorRole.PRIMARY);
+        viewThemeUtils.platform.colorImageView(binding.menuIconScanDocUpload, ColorRole.PRIMARY);
+        viewThemeUtils.platform.colorImageView(binding.menuIconMkdir, ColorRole.PRIMARY);
+        viewThemeUtils.platform.colorImageView(binding.menuIconAddFolderInfo, ColorRole.PRIMARY);


Not regarding video upload. Fixing Deprecation

JonasMayerDev

Works for me on OnePlus Nord 2 and code looks good to me.

alperozturk96 · 2024-06-18T07:32:40Z

Thanks for the PR and contribution. Amazing work 💯

I just did some small refactoring and add FIXME note for uploading video from emulator. I can't push commit for this branch because it's not branched out from our master branch.

Could you please apply this git patch? Then I can approve it and hopefully we can merge it 🙂

refactor.patch

timedin-de · 2024-06-18T08:42:35Z

@alperozturk96 Thank you for your work and time.

Until now i haven't worked with patches, when i just apply it I get an error. Should I just:

[1] undo my commit, apply the patch (with git apply refactor.patch or git am < refactor.patch and force-push or
[2] apply the patch on another branch (without my commit) and create a merge-commit to the fork-master branch with your refactors
[3] directly apply the patch to the current upstream master branch

And how do I have to handle signing off etc.

JonasMayerDev · 2024-06-18T11:59:53Z

@timedin-de not 100% sure but I would suggest number 1 ("remove your commits and add them via the patch back") since the patch seems to contain all changes you made compared to master. You can sign your commit with -S so eg. git commit -S -m "message" after you applied the patch

Signed-off-by: TimedIn <git@timedin.net>

timedin-de force-pushed the master branch from bd1cc5f to 1053aeb Compare May 9, 2024 14:14

timedin-de changed the title ~~Added upload from video camera #7358~~ Added upload from video camera May 9, 2024

timedin-de changed the title ~~Added upload from video camera~~ Added direct upload from video camera May 9, 2024

joshtrichards added enhancement 3. to review labels May 9, 2024

AndyScherzinger requested review from JonasMayerDev, tobiasKaminsky, alperozturk96 and ZetaTom May 11, 2024 06:34

alperozturk96 requested changes May 13, 2024

View reviewed changes

alperozturk96 force-pushed the master branch from 61c26a0 to 849bb8d Compare May 21, 2024 12:26

github-actions bot added the feedback-requested label May 24, 2024

timedin-de closed this May 28, 2024

timedin-de force-pushed the master branch from 849bb8d to 4ecce01 Compare May 28, 2024 17:08

timedin-de reopened this May 28, 2024

timedin-de commented May 28, 2024

View reviewed changes

timedin-de requested a review from alperozturk96 June 3, 2024 15:51

JonasMayerDev approved these changes Jun 17, 2024

View reviewed changes

alperozturk96 force-pushed the master branch from 91720d6 to b3b26b1 Compare June 18, 2024 06:56

timedin-de force-pushed the master branch from b3b26b1 to 06d88a3 Compare June 18, 2024 13:38

alperozturk96 approved these changes Jun 19, 2024

View reviewed changes

Add video upload from camera dialog

d00c157

Signed-off-by: TimedIn <git@timedin.net>

alperozturk96 force-pushed the master branch from 06d88a3 to d00c157 Compare June 19, 2024 08:27

alperozturk96 enabled auto-merge June 19, 2024 08:28

alperozturk96 disabled auto-merge June 19, 2024 08:28

AndyScherzinger added this to the Nextcloud App 3.30.0 milestone Jun 19, 2024

AndyScherzinger merged commit 5c6ddae into nextcloud:master Jun 19, 2024
18 of 20 checks passed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Added direct upload from video camera #12995

Added direct upload from video camera #12995

timedin-de commented May 9, 2024 •

edited

Loading

alperozturk96 left a comment •

edited

Loading

timedin-de commented May 14, 2024 •

edited

Loading

timedin-de commented May 21, 2024

alperozturk96 commented May 21, 2024

JonasMayerDev commented May 21, 2024

JonasMayerDev commented May 21, 2024 •

edited

Loading

timedin-de commented May 22, 2024

JonasMayerDev commented May 22, 2024

szaimen commented May 22, 2024

timedin-de commented May 22, 2024

szaimen commented May 22, 2024

JonasMayerDev commented May 22, 2024 •

edited

Loading

github-actions bot commented May 24, 2024

szaimen commented May 28, 2024

timedin-de commented May 28, 2024 •

edited

Loading

JonasMayerDev commented May 28, 2024

szaimen commented May 28, 2024

timedin-de commented May 28, 2024

timedin-de May 28, 2024

timedin-de May 28, 2024

timedin-de May 28, 2024

JonasMayerDev left a comment

alperozturk96 commented Jun 18, 2024 •

edited

Loading

timedin-de commented Jun 18, 2024 •

edited

Loading

JonasMayerDev commented Jun 18, 2024

Added direct upload from video camera #12995

Added direct upload from video camera #12995

Conversation

timedin-de commented May 9, 2024 • edited Loading

alperozturk96 left a comment • edited Loading

Choose a reason for hiding this comment

timedin-de commented May 14, 2024 • edited Loading

timedin-de commented May 21, 2024

alperozturk96 commented May 21, 2024

JonasMayerDev commented May 21, 2024

JonasMayerDev commented May 21, 2024 • edited Loading

timedin-de commented May 22, 2024

JonasMayerDev commented May 22, 2024

szaimen commented May 22, 2024

timedin-de commented May 22, 2024

szaimen commented May 22, 2024

JonasMayerDev commented May 22, 2024 • edited Loading

github-actions bot commented May 24, 2024

szaimen commented May 28, 2024

timedin-de commented May 28, 2024 • edited Loading

JonasMayerDev commented May 28, 2024

szaimen commented May 28, 2024

timedin-de commented May 28, 2024

timedin-de May 28, 2024

Choose a reason for hiding this comment

timedin-de May 28, 2024

Choose a reason for hiding this comment

timedin-de May 28, 2024

Choose a reason for hiding this comment

JonasMayerDev left a comment

Choose a reason for hiding this comment

alperozturk96 commented Jun 18, 2024 • edited Loading

timedin-de commented Jun 18, 2024 • edited Loading

JonasMayerDev commented Jun 18, 2024

timedin-de commented May 9, 2024 •

edited

Loading

alperozturk96 left a comment •

edited

Loading

timedin-de commented May 14, 2024 •

edited

Loading

JonasMayerDev commented May 21, 2024 •

edited

Loading

JonasMayerDev commented May 22, 2024 •

edited

Loading

timedin-de commented May 28, 2024 •

edited

Loading

alperozturk96 commented Jun 18, 2024 •

edited

Loading

timedin-de commented Jun 18, 2024 •

edited

Loading